Skip to content

Query plan, Offset Limit #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbhaskar merged 10 commits into from
Dec 19, 2019
Merged

Query plan, Offset Limit #6756

mbhaskar merged 10 commits into from
Dec 19, 2019

Conversation

@mbhaskar
Copy link
Member

@mbhaskar mbhaskar commented Dec 11, 2019

Porting query plan from v3 to v4
Porting offset-limit from v3 to v4
Removing enableCrossPartitionQuery from FeedOptions

@mbhaskar
Porting query plan from v3 to v4
4d60021 
Porting offset-limit from v3 to v4
Removing enableCrossPartitionQuery from FeedOptions
@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 11, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 11, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 11, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 11, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Merge branch 'feature/cosmos/upstream-v4' into v4/query-plan-offset-l…
5a8766a 
…imit

# Conflicts:
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/FeedOptions.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentQueryExecutionContextFactory.java
#	sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java
@mbhaskar
Merging v4
0f216bd
@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 14, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 14, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 16, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 16, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Merge branch 'feature/cosmos/upstream-v4' into v4/query-plan-offset-l…
6ec7e70 
…imit

# Conflicts:
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContext.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContextBase.java
@moderakh
Copy link
Contributor

moderakh commented Dec 17, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 17, 2019

Azure Pipelines successfully started running 1 pipeline(s).

moderakh
moderakh approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been reviewed when originally landed on v2. Looks good.

Just please run the CIs after feature/cosmosv4 was merged to make sure query still works.

@mbhaskar
Moving VeryLargeDocumentQueryTest to simple group from emulator as th…
ebffc8f 
…e test is passing on prod endpoint and failing on emulator when run locally

Fixing id in a test
@mbhaskar
Increasing timeout for offerquery test as this is passing locally both
e52dd70 
on emulator and prod
@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 18, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 18, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 19, 2019

Ran the readmywrites workflow on a VM.
#Successful Operations
count = 375729
mean rate = 128.24 events/second
1-minute rate = 106.76 events/second
5-minute rate = 105.70 events/second
15-minute rate = 114.03 events/second
#Unsuccessful Operations
count = 5
mean rate = 0.00 events/second
1-minute rate = 0.00 events/second
5-minute rate = 0.00 events/second
15-minute rate = 0.00 events/second

The 5 failures observed are because of NotYetConnected exception and filed an issue to track it.
#6955

kushagraThapar
kushagraThapar approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bringing this change on v4.

@mbhaskar mbhaskar merged commit 43fbc67 into Azure:feature/cosmos/v4 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@David-Noble-at-work David-Noble-at-work Awaiting requested review from David-Noble-at-work

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

+1 more reviewer

@moderakh moderakh moderakh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbhaskar @moderakh @kushagraThapar